gumyr / cq_warehouse

A cadquery parametric part collection
Apache License 2.0
107 stars 23 forks source link

dist folder doesn't belong here #44

Closed greyltc closed 2 years ago

greyltc commented 2 years ago

Hey, I think the dist folder you have here contains build artifacts that might not belong checked into revision control. If you merge your .gitignore with github's .gitignore template for python projects[1], that's a good start. Then this might me helpful to clean up the repo: https://stackoverflow.com/a/46273201 (I haven't actually tested this for correctness though!)

[1]: https://raw.githubusercontent.com/github/gitignore/main/Python.gitignore

gumyr commented 2 years ago

I'm certainly not an expert on this but I thought I needed the dist folder to store the pip whl and gz files - without them pip install wouldn't work, would it?

However, minimally the old versions shouldn't be there so I've removed them.

greyltc commented 2 years ago

Here's a 50,000 ft view of what pip install does: https://pip.pypa.io/en/stable/cli/pip_install/#overview Step 3 is to build the wheels (from the source). The source is the only thing that deserves to be tracked by the version control system.

gumyr commented 2 years ago

Thanks - dist is gone now.