search

gumyr / cq_warehouse

A cadquery parametric part collection
Apache License 2.0
107 stars 23 forks source link

Horizontal Extension Line #51

Closed slobberingant closed 1 year ago

slobberingant commented 2 years ago

In the drafting package, extension_line currently automatically detects the tangent that the label must be placed relative to it's dimensions. This results in a dimension that is 'aligned' with the points. Typical drafting applications allow for a 'horizontal' or 'vertical' dimension where the tangent is relative to the drawing plane.

horizontal_dimension

Extension_line can only create the dimension in red. Would it be possible to add the ability to create the dimension in black?

The function could accept a 'dimension_type' value which could be 'horizontal' or 'vertical'. Alternatively, it could be made to accept a label_tangent vector.

gumyr commented 2 years ago

I really like this idea. Reviewing your PR.

gumyr commented 1 year ago

Closed with PR61 content.

@slobberingant, thank you for improving cq_warehouse!