search

gumyr / cq_warehouse

A cadquery parametric part collection
Apache License 2.0
111 stars 24 forks source link

tapHole on an Assembly not modifying members of assembly #85

Open regattaguru opened 10 months ago

regattaguru commented 10 months ago

In your example 'Align Fastener Holes Example', tapHole is modifying 'square_tube', but not the one in 'square_tube_assembly'. Adding square_tube after the tapHole call (with a different ID of course) shows that the holes are added to the square_tube, but the instance already added is not perforated.

This is readily seen by exporting .step files and observing in a CAD system.

This could be a bug in Assembly, but my Python knowledge does not give me much chance of identifying that.

gumyr commented 10 months ago

I don't use cadquery any longer so something could definitely have changed that invalidates this example. I will be porting the remainder of cq_warehouse to bd_warehouse (https://bd-warehouse.readthedocs.io/en/latest/) which works with build123d (https://build123d.readthedocs.io/en/latest/index.html) where I will be able to provide better support.