search

gunar / medium-converter

Convert Medium posts to PDF, MOBI & EPUB
https://medium-converter.com/
52 stars 9 forks source link

Images are added to the article in a very misshaped size #12

Open vongohren opened 6 years ago

vongohren commented 6 years ago

Feks: https://media.consensys.net/blockchain-vs-distributed-ledger-technologies-1e0289a87b16

The pdf of this one becomse like the following pdf. With huge pictures which cuts of over half of the picture itself. media.consensys.net-blockchain-vs-distributed-ledger-technologies.pdf

Cl0v1s commented 6 years ago

I don't think it depends of this project but of Docverter, since this project does nothing more than retrieving Markdown from Medium and passing it to docverter, which manage the layout.

But since @DanielArthurUK is working on an image-related issue with Medium-parser (on which is also based this project), maybe you can take at look at his messages here.

Finally, I've forked this project to make it work with MarkdownToPdf instead of Docverter, maybe you could see if it resolves your problem as a temporary solution ? https://github.com/Clovis-Portron/medium-converter

vongohren commented 6 years ago

@Clovis-Portron well i went here: https://clovis-portron.github.io/medium-converter/ And from there i got a PDF on the same medium article, with no images. So I dont know what is best, to big or none :P

Cl0v1s commented 6 years ago

So it's definitely an issue with medium-parser, so let's wait for @DanielArthurUK's magic. :D

danarth commented 6 years ago

Yes this is an issue I highlighted with medium-parser, see gunar/medium-parser#13

I will be opening a PR to fix this in the coming days, but it is likely this fix will come in the form of a major version to fix other issues that currently exist with this library. The major version will change the way the library is used so you may have to change some of your existing code if you wish to upgrade.

Also, thank you for believing in me @Clovis-Portron 😂 I am not sure if it will be magic but hopefully it will work ✨

danarth commented 6 years ago

@Clovis-Portron just an update on this issue - I opened a PR last week for medium-parser, just waiting for @gunar to review and hopefully merge 🤞 Once that's done I'll open a PR here to update medium-converter to the new version. There are a bunch of other features too, feel free to check out my PR: gunar/medium-parser#15

Cl0v1s commented 6 years ago

Great job! I will take a look :D