gunar / medium-converter

Convert Medium posts to PDF, MOBI & EPUB
https://medium-converter.com/
52 stars 9 forks source link

Fix #3 #4

Closed Cl0v1s closed 6 years ago

Cl0v1s commented 6 years ago

Fixed Uncaught ReferenceError: fetchHTML is not defined at HTMLButtonElement.onclick (index.html:19)

gunar commented 6 years ago

Thank you. The build process seems to be broken, though. Am I doing something wrong?

Cl0v1s commented 6 years ago

I don't think so ! I've "patched" browserify on it (adding "browser" key in package.json, and filled the "dependencies" key). Maybe I've done something wrong when adding stuff in the dependencies key ?

I do not think we use the same building process since I only used browserify (I'm pretty new to all theese things), what's is yours ? :)

gunar commented 6 years ago

@Clovis-Portron Ok cool. But what command are you using to run it?

Cl0v1s commented 6 years ago

Simply browserify main.js -o index.js in the root folder.

But anyway, I will repare the building process and commit it here :)

gunar commented 6 years ago

@Clovis-Portron That would be awesome.

Btw, browserify main.js -o index.js throws as there is no file named main.js. My guess is that you forgot to commit some changes.

Let me know how I can help you!

matbrik commented 6 years ago

@gunar look at @Clovis-Portron first message, I guess that he renamed your index.js to main.js then he calls browserize to generate a new index.js made of all the dependencies grouped together in a single file from main.js

gunar commented 6 years ago

Alright. I am merging this. It seems to work, and it seems people want it. I'll fix the build script myself.

@Clovis-Portron @matbrik Thank you!

gunar commented 6 years ago

Seems to be working, let me know otherwise:

http://gunar.github.io/medium-converter