gund / eslint-plugin-deprecation

ESLint rule that reports usage of deprecated code
GNU Lesser General Public License v3.0
329 stars 38 forks source link

feat: add plugin meta and support typescript-eslint@7 #86

Closed JoshuaKGoldberg closed 4 months ago

JoshuaKGoldberg commented 5 months ago

Adds @typescript-eslint/utils@7 as an allowed version, as both 6 and 7 work with this package.

Adds a meta per https://eslint.org/docs/latest/extend/plugin-migration-flat-config#adding-plugin-meta-information as a non-breaking change. Adding in the meta actually fixes #85, since this plugin doesn't expose any preset config anyway.

Also swaps from the long-inactive tsutils to its successor, ts-api-utils. That's what @typescript-eslint/* packages use.

liquidg3 commented 5 months ago

@JoshuaKGoldberg - thanks for doing this. I'll have to disable the deprecation plugin for now, just to get the rest of our ecosystem onto eslint 9, but I'll be following this so we can bring it back once it's merged!

JoshuaKGoldberg commented 4 months ago

👋 since it's been a month, ping @gund - any chance you'd have time to look at this?

gund commented 4 months ago

btw what about these dev dependencies, shouldn't they also be updated to v7?

    "@typescript-eslint/eslint-plugin": "^6.0.0",
    "@typescript-eslint/rule-tester": "^6.0.0",
    "@typescript-eslint/parser": "^6.0.0",
gund commented 4 months ago

Seems like this breaks backwards compatibility with ESlint v7... I'm not sure if it's even worth fixing, maybe we could drop the support all together? In which case we need to remove v7 major from the eslint versions here: https://github.com/gund/eslint-plugin-deprecation/blob/ae8ca953b1b4cc2021525089f56ede97613e9311/package.json#L32 And also dropping the BC test for v7 from the matrix here: https://github.com/gund/eslint-plugin-deprecation/blob/ae8ca953b1b4cc2021525089f56ede97613e9311/.github/workflows/test.yml#L47-L55

What do you think @JoshuaKGoldberg?

JoshuaKGoldberg commented 4 months ago

I'm ok with that! ESLint v8 has been out for ... quite a while.

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: