search

gund / ng-dynamic-component

Dynamic components with full life-cycle support for inputs and outputs for Angular
https://malkevich-alex.gitbook.io/ng-dynamic-component/
MIT License
561 stars 65 forks source link

Support RxJS ^7.4.0 #467

Closed martibenn closed 2 years ago

martibenn commented 2 years ago

Since Angular support RxJS ^7.4.0 with @angular/common@13.1.X, would it be possible to upgrade ng-dynamic-component peer dependency on @angular/common and RxJS ?

Angular RxJS version : https://unpkg.com/browse/@angular/core@13.1.1/package.json 2021-12-16-15-21-01

ng-dynamic-component RxJS &@angular/common peer dependency : https://github.com/gund/ng-dynamic-component/blob/4bb0ed2b3fa88197a9bfe9b0edb95160f1015214/projects/ng-dynamic-component/package.json#L21 https://github.com/gund/ng-dynamic-component/blob/4bb0ed2b3fa88197a9bfe9b0edb95160f1015214/projects/ng-dynamic-component/package.json#L23

The error when adding ng-dynamic-component@10.0.0 on a 13.1.1 Angular problem : npm

Thanks !

gund commented 2 years ago

Hey @martibenn, thanks for the suggestion! Yes we can add support for rxjs v7 to peer deps! And we do not need to do any changes to angular deps as it allows any v13 version.

gund commented 2 years ago

:tada: This issue has been resolved in version 10.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: