search

gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.
GNU Lesser General Public License v2.1
13 stars 10 forks source link

Additional MINOS status codes #465

Open jedori0228 opened 5 months ago

jedori0228 commented 5 months ago

I found some cases where the MinosStatus() is 8 or 16, and currently it causes error at https://github.com/gundam-organization/gundam/blob/4938a3e70f25183ff3074e216c71b5687de4d7b4/src/Fitter/Minimizer/src/RootMinimizer.cpp#L299 as these are not defined at https://github.com/gundam-organization/gundam/blob/4938a3e70f25183ff3074e216c71b5687de4d7b4/src/Utils/include/GundamUtils.h#L51-L59

nadrino commented 5 months ago

Thank you very much for this issue!

Indeed, those status dictionary are quite outdated now and the use std::map is not very well suited to handle the messaging. I'll have a look in the near future.

ClarkMcGrew commented 1 month ago

Need to fix code so unknown errors have reasonable behavior. The line at RootMinimizer 299 is wrong.