search

gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.
GNU Lesser General Public License v2.1
13 stars 10 forks source link

Update JSON keys for overriding in gundamCalcXsec #483

Closed jedori0228 closed 3 months ago

jedori0228 commented 4 months ago

We recently updated gundam from 1.7.2 to 1.9.0, and noticed some structural changes in yaml. If I understand the update correctly, before we had 

"fitterEngineConfig": {
  "propagatorConfig": {
    "fitSampleSetConfig": {
      "fitSampleList": {

      }
    },
    "plotGeneratorConfig": {

    }
  }
}

but now we have

"fitterEngineConfig": {
  "likelihoodInterfaceConfig": {
    "dataSetManagerConfig": {
      "propagatorConfig": {
        "fitSampleSetConfig": {
          "fitSampleList": [

          ]
        },
        "plotGeneratorConfig": {

        }
      }
    }
  }
}

Please let me know if this is not what was intended! But if this is correct, I found the JSON overriding lines in gundamCalcXsec.cxx need to be changed as well, and tried to update them in this PR.

nadrino commented 4 months ago

Thank you very much for this PR, actually this reminds me that we need to find a more universal way to treat backward compatibility of the config files

nadrino commented 3 months ago

I'll close this PR as it was more broadly fixed in https://github.com/gundam-organization/gundam/pull/515