search

gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.
GNU Lesser General Public License v2.1
13 stars 10 forks source link

GUNDAM 1.8.0: LLH scans aborted #485

Closed riccioc closed 4 months ago

riccioc commented 4 months ago

LLH scans aborted with this message:

terminate called after throwing an instance of 'std::runtime_error' what(): exception thrown by the logger: std::isnan(llh) or std::isinf(llh)

The command used is

gundamFitter -d --scan -c configOA2024.yaml -t 32 -of override/noEigen.yaml

I have added the override to disable the eigen-decomposition to test it was not causing the issue.

I think this was solved in 1.9.0 or in the main but we should have this fixed in version 1.8.X since we decided that this should be the LTS version. I didn't check but this may affect also the sigma variations.

ClarkMcGrew commented 4 months ago

I am going to create a branches for longer support and we should start being careful about 1.8.0 tags and release candidates. I'll add thoughts on slack for specifics.

ClarkMcGrew commented 4 months ago

I'll tackle this. The branch will be LTS/issue485/LLHNotANumber. It's hard to create a simple test to demonstrate the bug, but the main issue is that "inf" is a valid likelihood, so it should be accepted. In any case, that should not cause the program to crash.