GUNDAM 1.8.0: Catmull Rom extrapolation is not linear

gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.

GNU Lesser General Public License v2.1

13 stars 10 forks source link

GUNDAM 1.8.0: Catmull Rom extrapolation is not linear #486

Closed ClarkMcGrew closed 4 months ago

ClarkMcGrew commented 4 months ago

The Catmull-Rom splines are not extrapolating correctly. This is mostly harmless since fits should avoid extrapolation, but can cause unexpected behavior. It can be seen by asking for spline values outside of the range of the provided knots.

ClarkMcGrew commented 4 months ago

This is being fixed in LTS/issue486/SplineExtrapolation

ClarkMcGrew commented 4 months ago

The issue can be seen running the tests/100CheckCompactSpline.C and tests/100CheckMonotonicSpline.C scripts which construct hand built inputs for CalculateCompactSpine and CalculateMonotonicSpline.

ClarkMcGrew commented 4 months ago

This will be closed by #487