search

gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.
GNU Lesser General Public License v2.1
13 stars 10 forks source link

Fix branch notify on LTS #498

Closed nadrino closed 3 months ago

ClarkMcGrew commented 4 months ago

I don't see any issue describing the problems for this fix, and this seems to be doing two entirely different things. For our change log tracking we need to know what is being fixed, and why:

  1. In 3cade59, what is fixed by "fixing branch enabling"? It's actually changing the submodule commit, and it looks like the branch status being turned on (branches weren't enabled elsewhere?).
  2. In 81f6ec6, why is the check for minuit2 being removed? Are we safe to assume that all versions of root that might be used will always have Minuit2? Did the root fitting get updated to not ever need Minuit2?

This doesn't look ready to merge.

ClarkMcGrew commented 3 months ago

Clean version of pull added to LTS/1.8.x by #500