search

gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.
GNU Lesser General Public License v2.1
13 stars 11 forks source link

Resolve Issue 492: Remove compilation warnings with NVCC #503

Closed ClarkMcGrew closed 5 months ago

ClarkMcGrew commented 5 months ago

This merge is fixing several testing bugs, as well as the main purpose of removing compilation warnings seen with NVCC,

  1. Fix a lot of NVCC errors. There are still some errors in the generic tool kit code, but the problems appear to be coming with code using C functions, so it needs a rewrite.
  2. Fix a test that got missed when issue #494 was resolved.
  3. Add tests for all hemi. These are unit tests using googletest and will only be run if googletest is installed on the building machine. There is also a new upstream version of hemi that we can import later (maybe)
  4. Enable checks for valid inputs that had been disabled (probably as part of some past debugging). The checks should never be triggered, but if they are triggered, the fit will be wrong.
ClarkMcGrew commented 5 months ago

I'm going to merge and close. This will close #492 and #502.