LTS 1.8.x : Cache::Manager atomic addition and multiplication not guarranteed to be atomic on host

gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.

GNU Lesser General Public License v2.1

13 stars 10 forks source link

LTS 1.8.x : Cache::Manager atomic addition and multiplication not guarranteed to be atomic on host #510

Closed ClarkMcGrew closed 1 month ago

ClarkMcGrew commented 2 months ago

This is mostly harmless since the Cache::Manager usage is almost always single threaded on the host, but it could lead to mysterious bugs in the future.

ClarkMcGrew commented 1 month ago

It's not as harmless as I thought. The IndexedSum does very badly when there is any possibility of threads interfering with the calculation (using the CPU with CacheManager). It's not a normal running configuration, but will badly mess up the calculation.