search

gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.
GNU Lesser General Public License v2.1
13 stars 11 forks source link

Lts/issue566/bad test binning #567

Closed ClarkMcGrew closed 1 month ago

ClarkMcGrew commented 1 month ago

The "reconstructed" histograms were being constructed with one of the bins truncated. That caused some of the events to be missing in the likelihood. This fixes the histograms to cover the entire region, and then updates the expected test values for the new binning. It also sets an explicit tolerance in the config file so that the results are more stable.

Note: Setting the tolerance to 1.0E-6 fixes a problem noted during a working session that the MIGRAD errors were very inaccurate. The MIGRAD errors now agree rather well with the HESSE errors.

ClarkMcGrew commented 1 month ago

Strike the last comment because I didn't notice differences between LTS and main. The LTS sees agreement between the MIGRAD results and the HESSE results (both values and errors, but the values "must" be the same). The main code is converging to a nearby, but different point, and is getting reporting different values for MIGRAD and HESSE.

ClarkMcGrew commented 1 month ago

This branch is ready to be merged into LTS/1.8.x.