search

gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.
GNU Lesser General Public License v2.1
13 stars 11 forks source link

Prevent parameter values outside of the bounds #577

Closed ClarkMcGrew closed 2 months ago

ClarkMcGrew commented 2 months ago

This is forward porting the fixes in LTS/1.8.x that prevent parameters from being set to values outside of their defined domain. If a parameter gets a value outside of its domain an error will be thrown.

nadrino commented 2 months ago

Why is that necessary? Sometimes the fitter will explore outside of bounds. More generally I guess we could let the use explore outside of bounds. The parameter limits are only relevant for the fit, right?

ClarkMcGrew commented 2 months ago

Huh? No. Parameter values outside of the bounds are a bug, pure and simple.