gundam-organization / gundam

GUNDAM, for Generalized and Unified Neutrino Data Analysis Methods, is a suite of applications which aims at performing various statistical analysis with different purposes and setups.
GNU Lesser General Public License v2.1
13 stars 11 forks source link

LTS/1.8.x : MINUIT variables bounds not correctly set #580

Closed ClarkMcGrew closed 1 month ago

ClarkMcGrew commented 1 month ago

The variable MINUIT variable definitions for bounded parameters are being done incorrectly.

There are three different bound setting calls for Minuit: SetVariableLimits(), SetVariableLowerLimit(), and SetVariableUpperLimit(). The versions for the upper and lower limit cause the "other" limit to be removed. MinimizerInterface is incorrectly using SetVariableLowerLimit() and SetVariableUpperLimit() in sequence, so the variable lower limit is usually ignored.

A separate issue is filed for the same problem in the main branch.