gundermanc / vs-go

Hack and slash Go language service prototype for VS Win + VS Mac
MIT License
8 stars 2 forks source link

Added synchronization map in languageservice #39

Closed shivasin-ms closed 5 years ago

gundermanc commented 5 years ago

I'm seeing errors when building:

Severity Code Description Project File Line Suppression State Error ..\languageservice\workspace.go:19:36: too few values in workspaceManager literal Go.Interop C:\repos\vs-go\src\Go.Interop\Go.Interop.csproj 25

gundermanc commented 5 years ago

Note that the CI doesn't currently build the Go portion.

shivasin-ms commented 5 years ago

The same error I was seeing before adding my changes, let me check if something is missing in the declaration if this struct.

Thanks, Shivam Singh

Microsoft Intune

[microsoft]

From: Christian Gunderman notifications@github.com Sent: Monday, July 22, 2019 1:38 PM To: gundermanc/vs-go vs-go@noreply.github.com Cc: Shivam Singh Shivam.Singh@microsoft.com; Author author@noreply.github.com Subject: Re: [gundermanc/vs-go] Added synchronization map in languageservice (#39)

I'm seeing errors when building:

Severity Code Description Project File Line Suppression State Error ..\languageservice\workspace.go:19:36: too few values in workspaceManager literal Go.Interop C:\repos\vs-go\src\Go.Interop\Go.Interop.csproj 25

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgundermanc%2Fvs-go%2Fpull%2F39%3Femail_source%3Dnotifications%26email_token%3DAMVZ5DT2ZRENX44XZ3XMQOTQAYLDZA5CNFSM4IF3ZARKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2RCZ5Q%23issuecomment-513944822&data=02%7C01%7CShivam.Singh%40microsoft.com%7C7ac8477ad98d47f1607c08d70ee488ca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636994247014758621&sdata=Y95aRt6MRW5iXye%2F9yHAMEg7nwf0LdsKsYygcpjxTDE%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMVZ5DQ2ZMJ7RRRDOG52UELQAYLDZANCNFSM4IF3ZARA&data=02%7C01%7CShivam.Singh%40microsoft.com%7C7ac8477ad98d47f1607c08d70ee488ca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636994247014758621&sdata=NxLZQuh56bmZF1mGNrJ3OW4pU8qKaWosNq%2FHtCewyIk%3D&reserved=0.

shivasin-ms commented 5 years ago

I missed this thing, fixed it now.