search

guness / bitrise-step-firebase-app-distribution

Upload your apps to Firebase and sends email to your testers.
MIT License
35 stars 28 forks source link

Release notes exceeds maximum character limit #41

Closed josinaldobarbosa closed 3 years ago

josinaldobarbosa commented 3 years ago

Error: failed to update release notes with HTTP Error: 400, Release notes length exceeds maximum character limit

I think my release notes are 71696 characters. I saw on the console that the maximum accepted is 16384 characters (manually found out), I didn't find any limit value in the doc for cli.

guness commented 3 years ago

can you please report this to firebase developers? we can't control limits on this step.

josinaldobarbosa commented 3 years ago

It doesn't make sense to me, if there is a limit we must respect, I created a PR that at least prevents the step from breaking the build

guness commented 3 years ago

I am sorry for the effort you put in but I have to disagree. As an end-user, I would piss off if a step decides to truncate my input.

Besides, this step is not managing the limit. So can you think of what happens when firebase decides to increase or decrease this limit? The step will be either truncating for nothing, or it will false promise safety.

josinaldobarbosa commented 3 years ago

understand, thank you for the answer