search

guness / node-xcs

NodeJS implementation of Google's XMPP Connection Server
BSD 2-Clause "Simplified" License
38 stars 23 forks source link

Consider updating docs to use senderId rather than projectId #5

Closed javamonn closed 8 years ago

javamonn commented 8 years ago

I think it's worth considering updating at least the README to use senderId rather than projectId. I for one ran into an initial configuration issue by attempting to create a new sender with my GCP project ID instead of the GCM sender ID - didn't notice the discrepancy until I took a look at the GCM reference docs. Would you accept a quick PR for this?

guness commented 8 years ago

Seems well, will do on next commit.

guness commented 8 years ago

this commit fixes the issue: https://github.com/guness/node-xcs/commit/9f9e1c478594787d49505bec1e79fab608cd8bf0