gunnarmorling / 1brc

1️⃣🐝🏎️ The One Billion Row Challenge -- A fun exploration of how quickly 1B rows from a text file can be aggregated with Java
https://www.morling.dev/blog/one-billion-row-challenge/
Apache License 2.0
6.09k stars 1.83k forks source link

Small optimization for ebarlas submission. #523

Closed ebarlas closed 8 months ago

ebarlas commented 8 months ago

Check List:

gunnarmorling commented 8 months ago

Hum, hum, getting this test failure now:

Validating calculate_average_ebarlas.sh -- src/test/resources/samples/measurements-rounding.txt
2c2
< jel;-9.0;17.9;46.5
---
> jel;-9.0;18.0;46.5

FAILURE: ./test.sh ebarlas failed
ebarlas commented 8 months ago

Oh no! How strange. I'll look around. No idea what that could be.

ebarlas commented 8 months ago

Fixed! There was indeed a bug surfaced with that specific test and a parallelism of 32 (your env, apparently).

A few lines were getting reprocessed due to a line-start book-keeping bug.

gunnarmorling commented 8 months ago

Ah, that's interesting. Hard to catch indeed. Could you rebase and force-push this one? I've just changed the GH Action run for PRs, so it should run tests against the submitter's entry now (wouldn't have caught this one probably as it doesn't run with 32 cores, but others it should).

ebarlas commented 8 months ago

I'll do that shortly!

ebarlas commented 8 months ago

Updated!

gunnarmorling commented 8 months ago

Sweet, this looks good in the CI build now: https://github.com/gunnarmorling/1brc/actions/runs/7602797389/job/20703748694. This should save some time going forward.

gunnarmorling commented 8 months ago

00:03.990 now, nice!