Initial submission for varunsankethi

gunnarmorling / 1brc

1️⃣🐝🏎️ The One Billion Row Challenge -- A fun exploration of how quickly 1B rows from a text file can be aggregated with Java

https://www.morling.dev/blog/one-billion-row-challenge/

Apache License 2.0

6.23k stars 1.87k forks source link

Initial submission for varunsankethi #604

Closed varunsankethi closed 9 months ago

varunsankethi commented 9 months ago

Check List:

[x ] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[x] All formatting changes by the build are committed
[x] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[x] Output matches that of calculate_average_baseline.sh
[ ] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
Execution time: 1 minutes 45 seconds
Execution time of reference implementation: 2 minutes 25 seconds

gunnarmorling commented 9 months ago

Hey, as per the README and the PR template, new entries at this point should run in about 10 sec on the eval machine, so as to keep things manageable somewhat. It's not a hard and fast rule, but as per the time you share and from a quick glance at the implementation this does seem way closer to the original base line. Do you think you could it improve it to get somewhere up there? If not, I'd rather we close this PR at this point. Thanks a lot!

varunsankethi commented 9 months ago

Thanks for the feedback, I will try to reduce the running time and raise another PR in case it is under 10 seconds. Closing this PR.

gunnarmorling commented 9 months ago

Thank you, appreciate it! Thanks a lot for participating in any case.