Mahadev virtual thread 1brc

gunnarmorling / 1brc

1️⃣🐝🏎️ The One Billion Row Challenge -- A fun exploration of how quickly 1B rows from a text file can be aggregated with Java

https://www.morling.dev/blog/one-billion-row-challenge/

Apache License 2.0

6.23k stars 1.87k forks source link

Mahadev virtual thread 1brc #611

Closed mahadev-k closed 9 months ago

mahadev-k commented 9 months ago

Check List:

[x] Tests pass (./test.sh <username> shows no differences between expected and actual outputs) ./test.sh mahadev_k
[x] All formatting changes by the build are committed
[x] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable ./calculate_average_mahadev_k.sh
[x] Output matches that of calculate_average_baseline.sh
[x] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
Execution time: 1.5min Max
Execution time of reference implementation:

gunnarmorling commented 9 months ago

Please make sure that the scripts match your actual GH account name ("-" vs. "_"). Also note that new entries at this point should come in at ~10 sec to keep things manageable with the large number of entries so far.

mahadev-k commented 9 months ago

I have updated the names as per the GH username. calculate_average_mahadev-k.sh ./prepare_mahadev-k.sh

Sorry for the inconvenience. Please review and build the project again.

gunnarmorling commented 9 months ago

Please make the scripts executable.

mahadev-k commented 9 months ago

Added chmod +x for the prepare and calculate mahadev-k .sh files.

gunnarmorling commented 9 months ago

01:53.208.

mahadev-k commented 9 months ago

In the mac book pro - 32GB RAM and Apple M2 this takes only around 60-70 seconds though..