gunnarmorling / 1brc

1️⃣🐝🏎️ The One Billion Row Challenge -- A fun exploration of how quickly 1B rows from a text file can be aggregated with Java
https://www.morling.dev/blog/one-billion-row-challenge/
Apache License 2.0
6.08k stars 1.83k forks source link

serkan-ozal's 3rd submission with some minor improvements #615

Closed serkan-ozal closed 7 months ago

serkan-ozal commented 7 months ago

Check List:

serkan-ozal commented 7 months ago

Hi @gunnarmorling,

I have sent my 3rd submission. Even though I don't see performance improvement in my testing env, it still might perform better in the eval machine as there are some major changes. Let's see how it will be in the eval machine.

Thanks in advance.

gunnarmorling commented 7 months ago

Yepp, slower indeed:

Benchmark 1: timeout -v 300 ./calculate_average_serkan-ozal.sh 2>&1
  Time (mean ± σ):      2.648 s ±  0.041 s    [User: 0.003 s, System: 0.006 s]
  Range (min … max):    2.605 s …  2.710 s    5 runs

Summary
  serkan-ozal: trimmed mean 2.6423087684, raw times 2.6048885754,2.7095721204000003,2.6545993044,2.6181676104,2.6541593904000003

Leaderboard
grep: ./src/main/java*/dev/morling/onebrc/CalculateAverage_serkan-ozal.java: No such file or directory

| # | Result (m:s.ms) | Implementation     | JDK | Submitter     | Notes     |
|---|-----------------|--------------------|-----|---------------|-----------|
|   | 00:02.642 | [link](https://github.com/gunnarmorling/1brc/blob/main/src/main/java/dev/morling/onebrc/CalculateAverage_serkan-ozal.java)| 21.0.1-open | [Serkan ÖZAL](https://github.com/serkan-ozal) |  |
serkan-ozal commented 7 months ago

Hi @gunnarmorling,

I have updated the optimizations:

In my testing environment, it has improved the performance by 200 ms. Will see how much it will be in the eval machine.

Could you please rerun it?

gunnarmorling commented 7 months ago

Yepp, makes for small improvement: 00:02.440 now.