Attempt to fix segfault CalculateAverage_zerninv.java

gunnarmorling / 1brc

1️⃣🐝🏎️ The One Billion Row Challenge -- A fun exploration of how quickly 1B rows from a text file can be aggregated with Java

https://www.morling.dev/blog/one-billion-row-challenge/

Apache License 2.0

6k stars 1.8k forks source link

Attempt to fix segfault CalculateAverage_zerninv.java #635

Closed zerninv closed 6 months ago

zerninv commented 7 months ago

Check List:

[x] You have run ./mvnw verify and the project builds successfully
[x] Tests pass (./test.sh zerninv shows no differences between expected and actual outputs)
[x] All formatting changes by the build are committed
[x] Your launch script is named calculate_average_zerninv.sh (make sure to match casing of your GH user name) and is executable
[x] Output matches that of calculate_average_baseline.sh
[x] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
Execution time: 13s
Execution time of reference implementation: 6m

I see that my solution gives segfault for 10k dataset. Unfortunately can not reproduce it locally so change my solution a bit as an attempt to avoid segfault

gunnarmorling commented 7 months ago

The output differs from the expected one for the 10K key set now:

Validating calculate_average_zerninv.sh -- measurements_10K_1B.txt
Picking up existing native image 'target/CalculateAverage_zerninv_image', delete the file to select JVM mode.
2408c2408
< arlisleGarissaLisalaNitr;-11.0;17.6;48.5
---
> arlisleGarissaLisalaNitr;-11.0;17.7;48.5
3914c3914
< fkl;-16.4;14.8;44.4
---
> fkl;-16.4;14.7;44.4

FAILURE: ./test.sh zerninv measurements_10K_1B.txt failed

zerninv commented 7 months ago

@gunnarmorling would you mind to check it one more time. locally outputs match with baseline (or top) solution.

gunnarmorling commented 6 months ago

00:03.785 now, passing for the 10K keyset too. Nice!

gunnarmorling commented 6 months ago

Hey @zerninv!

Congrats again on being in the Top 20 of the One Billion Row Challenge!

To celebrate this amazing achievement, I would like to send you a 1BRC t-shirt and coffee mug. To claim your prize, fill out this form by Feb 18. After submitting the form, please provide a comment with the random value you've specified in the form, so that I know it is you who submitted it.

All data entered will solely be used in relation to processing this shipment. Shipments can be sent to any country listed here or here (I'll use whichever one is cheaper for me to ship to your location). A big thank you to Decodable for sponsoring these prizes!

Thanks a lot for participating in 1BRC,

--Gunnar

zerninv commented 6 months ago

Hey @gunnarmorling, Thanks again for this challenge. My random is: 11960 13079