gunnarmorling / 1brc

1️⃣🐝🏎️ The One Billion Row Challenge -- A fun exploration of how quickly 1B rows from a text file can be aggregated with Java
https://www.morling.dev/blog/one-billion-row-challenge/
Apache License 2.0
6k stars 1.8k forks source link

melgenek: minor improvements #655

Closed melgenek closed 6 months ago

melgenek commented 7 months ago

Check List:

These changes cut ~1s out of 6s in a Lima VM with 8 cores.

gunnarmorling commented 6 months ago

This runs out of heap space for the 10K key set (see _create_measurements_3.sh) when testing with 32 cores:

Terminating due to java.lang.OutOfMemoryError: Java heap space
melgenek commented 6 months ago

Sorry, forgot to make the change to add more memory.

@gunnarmorling I was testing locally only against the 10k dataset. While you're testing 10k anyway, could you please tell me how much time it takes to process 10k on the target machine?

gunnarmorling commented 6 months ago

Looking good now. 00:05.167 now. 00:07.137 for the 10K key set.