gunnarmorling / 1brc

1️⃣🐝🏎️ The One Billion Row Challenge -- A fun exploration of how quickly 1B rows from a text file can be aggregated with Java
https://www.morling.dev/blog/one-billion-row-challenge/
Apache License 2.0
6.14k stars 1.85k forks source link

EduardoSaverin #689

Closed EduardoSaverin closed 8 months ago

EduardoSaverin commented 8 months ago

UserName : EduardoSaverin Total Time : 15.408 CPU : 8 Core (Apple M1 Pro) RAM : 16GB Collision Handling Line Number : 122 Output Checked by running and matching calculate_average_baseline.sh

Check List:

Execution Times on my machine

gunnarmorling commented 8 months ago

Fails a test when running on 32 cores of the eval machine:

+ timeout -v 300 ./test.sh EduardoSaverin
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-10000-unique-keys.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-10.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-1.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-20.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-2.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-3.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-boundaries.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-complex-utf8.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-dot.txt
Validating calculate_average_EduardoSaverin.sh -- src/test/resources/samples/measurements-rounding.txt
2c2
< jel;-9.0;17.4;46.5
---
> jel;-9.0;18.0;46.5

FAILURE: ./test.sh EduardoSaverin failed
Summary
  EduardoSaverin: command failed or output did not match
EduardoSaverin commented 8 months ago

@gunnarmorling Hi, Sorry for this, but it seems when I ran this it worked fine. I looked upon this problem and found it was sometimes causing issue. Now I have fixed this can you please again run this on 32 Cores.

gunnarmorling commented 8 months ago

Looking good now: 00:05.336.