gunnarmorling / 1brc

1️⃣🐝🏎️ The One Billion Row Challenge -- A fun exploration of how quickly 1B rows from a text file can be aggregated with Java
https://www.morling.dev/blog/one-billion-row-challenge/
Apache License 2.0
5.69k stars 1.72k forks source link

Submission for Smoofie #701

Closed Smoofie closed 5 months ago

Smoofie commented 5 months ago

Check List:

gunnarmorling commented 5 months ago

This seg faults on 32 cores for the 10K key set test (see create_measurements_3.sh). Note that we're after the cut-off time, so you'll have two more changes you can make to this PR (see note at the top of the README). If it's not working or valid then, I'll have to close it unfortunately. Updates should be pushed quickly, so I can evaluate all the pending entries. Thx!

< #
< # A fatal error has been detected by the Java Runtime Environment:
< #
< #  SIGSEGV (0xb) at pc;0x00007fc654a1dad1
< pid;1855790
< tid;1855813
< #
< # JRE version: OpenJDK Runtime Environment (21.0.1+12) (build 21.0.1+12-29)
< # Java VM: OpenJDK 64-Bit Server VM (21.0.1+12-29
< mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
< # Problematic frame:
< # J 111 c1 sun.misc.Unsafe.getInt(J)I jdk.unsupported@21.0.1 (8 bytes) @ 0x00007fc654a1dad1 [0x00007fc654a1da20+0x00000000000000b1][thread 1855816 also had an error]
< #
< #
< Core dump will be written. Default location: Core dumps may be processed with ";usr;lib;systemd;systemd-coredump %P %u %g %s %t %c %h" (or dumping to ;home;build;projects;eval;1brc;core.1855790)
< #
< # An error report file with more information is saved as:
< # ;home;build;projects;eval;1brc;hs_err_pid1855790.log
< [thread 1855811 also had an error]
< [thread 1855812 also had an error]
< [thread 1855814 also had an error]
< [thread 1855822 also had an error]
< [thread 1855815 also had an error]
< [thread 1855817 also had an error]
< [thread 1855819 also had an error]
< [thread 1855826 also had an error]
< [thread 1855818 also had an error]
< [thread 1855835 also had an error]
< [thread 1855832 also had an error]
< [thread 1855828 also had an error]
< [thread 1855823 also had an error]
< [thread 1855825 also had an error]
< [thread 1855824 also had an error]
< [thread 1855834 also had an error]
< [thread 1855821 also had an error]
< [thread 1855833 also had an error]
< [thread 1855836 also had an error]
< [thread 1855840 also had an error]
< [thread 1855838 also had an error]
< [thread 1855830 also had an error]
< [thread 1855837 also had an error]
< [thread 1855831 also had an error]
< [thread 1855841 also had an error]
< [0.081s][warning][os] Loading hsdis library failed
< [thread 1855810 also had an error]
< [thread 1855820 also had an error]
< #
< # If you would like to submit a bug report, please visit:
< #   https:;;bugreport.java.com;bugreport;crash.jsp
< #
Smoofie commented 5 months ago

@gunnarmorling Thank you for the feedback! I've solved the seg fault issue and pushed the new version

gunnarmorling commented 5 months ago

Looking good now: 00:07.948. Also passing for 10K keys.