search

gunnarx / franca_install_automation

Private repo NOT CURRENTLY SUPPORTED - I recommend to refer to (http://github.com/genivi/eclipse_install_automation). Scripted installation of Eclipse+Franca Tools on a machine, or creation of a new Virtual Machine image. Please read README.md for instructions on which branch to use and known bugs.
Mozilla Public License 2.0
5 stars 4 forks source link

Support using Luna or Mars release of Eclipse. #17

Closed kbirken closed 6 years ago

kbirken commented 9 years ago

Added easy-to-use configuration switch for choosing an Eclipse version. Just set ECLIPSE_DISTRO to either luna or mars. This might become a multi-case decision as soon as Neon is available.

Also introduced a list of possible mirrors for download (which currently has only two entries). Just set USE_ECLIPSE_MIRROR to one of the mirrors from the list.

gunnarx commented 9 years ago

As a summary I would have preferred to get a new PR fixing the stuff, but it's quick so I fix it myself.

I probably want Mars only (as I said, the main idea is to choose few defaults for the user, and to remove choices and complexity - most configurability are kept on different branches because I prefer that)

I'll accept the pull on master branch (so you get credit for providing the URLs and MD5s for Mars :-) but I'll remove the variability directly after.

Once tested enough we can merge this to the actual user branches and leave Luna behind and use Mars only on all of them.

I would appreciate help/opinion on that. Is everything working with Mars as it should?

gunnarx commented 9 years ago

OR: Do you need Luna to be kept for your testing? I could revert that change for a while, no problem...

kbirken commented 9 years ago

I certainly need to switch between Luna and Mars for Franca release candidates. However, I can adapt to the concept of CONFIG simplicity and make the necessary changes on a local branch.

gunnarx commented 9 years ago

Or I can maintain such a branch also, no problem if you want me to merge updates for you.

Some questions in that case: When testing do you typically use the vagrant build or use the install script directly on a host? If vagrant, do you test on only one of the variants (for example trusty64 etc)?

kbirken commented 9 years ago

I use the vagrant build for testing to be sure to get a completely new environment each time. And yes, I use trusty64-lxde. So a branch with Luna would be fine :-)

gunnarx commented 9 years ago

I see. In that case maybe you want to keep site_franca.zip also, to test new release candidates before they make it to the update site? (If you place the zip locally it is not downloaded so it's an idea)

Because I just switched to using the update site instead which you may have seen. I was not considering your testing use case, only the end user.

gunnarx commented 6 years ago

This is obsolete now. A new PR updating to an appropriate newer version might make sense, though.