Use release phase instead

gunpowderlabs / buildpack-ruby-rake-deploy-tasks

Run arbitrary rake tasks on deploy to Heroku

MIT License

146 stars 79 forks source link

Use release phase instead #14

Closed schneems closed 7 years ago

schneems commented 7 years ago

Can we recommend people use release phase in the readme? https://devcenter.heroku.com/articles/release-phase

azolotov commented 7 years ago

@schneems Yes. Want to send a PR?

taylorzr commented 7 years ago

Seems like there are a few problems here:

Heroku says:

Buildpack developers should avoid generating side effects during the build. For example, it is not recommended to perform database migrations in the compile script.
But the release phase is still in beta

I don't think it makes sense to deprecate this gem entirely until the release phase is out of beta.

azolotov commented 7 years ago

@schneems I think @taylorzr is right. We shouldn't deprecate this until it's out of beta, and supports side effects like running DB migrations.

I added a note to the readme linking to Release Phase.

schneems commented 7 years ago

DB migrate works just fine. That's what I use it for.

There are reasons to not do this at scale though, for example if you accidentally lock a HUGE table there is no way to stop or cancel the release phase. That's why we don't officially recommend using it for DB migrate. In practice it's what most smaller and medium apps I've seen use it for.