gunschu / jitsi_meet

Initial commit
207 stars 280 forks source link

[UPGRADE]: android gradle to 4.0.1 and gradle to 6.1.1 #246

Open tuantvu opened 3 years ago

tuantvu commented 3 years ago

Dependency Information Name: gradle-wrapper.properties Version: distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip Name: build.gradle Version: dependencies { classpath 'com.android.tools.build:gradle:4.0.1' } Platform

Reason for upgrade

Conform to official Jitsi meet example

Provide additional context

https://github.com/jitsi/jitsi-meet-sdk-samples/tree/master/android/java/JitsiSDKTest

aliyazdi75 commented 2 years ago

Hi @tuantvu Because of some dependencies like org.jitsi.meet.sdk.ConnectionService, org.jitsi.meet.sdk.JitsiMeetOngoingConferenceService and org.jitsi.meet.sdk.JitsiMeetActivity, android:exported hasn't been mentioned in their activity or service, we can't run the project for android API 31 and getting this error: Manifest merger failed : android:exported needs to be explicitly specified for <service>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

When do you think it will be updated to the new versions of dependencies?

aliyazdi75 commented 2 years ago

I could solve this issue by adding this to our manifest:

        <service android:name="org.jitsi.meet.sdk.ConnectionService"
            android:exported="false"
            tools:node="merge" />

But it would be better to solve this by the package.

ektapadaliya commented 2 years ago

@aliyazdi75 Where to add on manifest ?

aliyazdi75 commented 2 years ago

@aliyazdi75 Where to add on manifest ?

under application tag.