search

gunziptarball / airflow-provider-alembic

Run Alembic via Airflow
MIT License
1 stars 1 forks source link

Downgrade Operator #5

Closed ramdesh closed 3 years ago

ramdesh commented 3 years ago

I see that the test is running both upgrade and downgrade in a single rev using the upgrade operator. Do we need a separate upgrade operator?

gunziptarball commented 3 years ago

Not quite sure I completely understand the question, but yeah, I imagined we should also write an AlembicDowngradeOperator to complement the AlembicUpgradeOperator.

Can you reference the specific code points you're referring to regarding "both upgrade and downgrade in single rev?"

ramdesh commented 3 years ago

Looks like I made a mistake there, I forgot that you needed the rollback logic inside a revision as well. I'll take the creation of the downgrade operator.

gunziptarball commented 3 years ago

Looks like #6 closes this. Thanks! :)