search

guo-yu / btc

a command-line bitcoin price board for geeks
MIT License
389 stars 73 forks source link

j/k keybindings to move down/up #2

Closed artagnon closed 10 years ago

artagnon commented 10 years ago

A small token of gratitude.

vincemtnz commented 10 years ago

:+1: for vim keybindings! However... the above functionality was added in node-term-list in this commit: visionmedia/node-term-list@818e1846002dc8ea775e9017262a722676c130ea

Since binding to keys does not override the default functionality, this change will break navigation if any updates to node-term-list are published (since we're tracking "*" :angry: ). Current version is 0.2.0, I'd suggest we simply point to visionmedia/node-term-list in package.json. What do you think?

Basically, what I did in this commit: eyko/btc@60f25e43c0b5daee3f696b8925ea559e72303293 adds j/k keybindings as a result of pointing to node-term-list master.

I do prefer the switch syntax over if/else if/else if.

artagnon commented 10 years ago

Sure, 60f25e4 seems to do the right thing. Thanks for the explanation.