search

guo-yu / player

a command line player, supports play mp3 both from uri and local stream.
261 stars 66 forks source link

Pause patch #48

Closed ewnd9 closed 8 years ago

ewnd9 commented 8 years ago

On pause audio stop playing with ~1 sec delay, resume works immediately. Also please keep in mind like in previous pull request I didn't include rebuilded dists, so you need to do it before publishing new version on npm

guo-yu commented 8 years ago

Sure, thank you so much

ewnd9 commented 8 years ago

:tada:

kingdido999 commented 8 years ago

@ewnd9 Hi, I'm experiencing a 1~2 secs delay on pause() and stop() when playing from url with stream enabled. I noticed that both methods are calling:

this.speaker.Speaker.end()

which means it's an issue with node-speaker? Is there any room for speed improvement? Thank you.

ewnd9 commented 8 years ago

@kingdido999 Yep, I suppose it's related to https://github.com/TooTallNate/node-speaker/issues/13 or https://github.com/TooTallNate/node-speaker/pull/37

kingdido999 commented 8 years ago

@ewnd9 Thanks, I'll look into them.