guoguibing / librec

LibRec: A Leading Java Library for Recommender Systems, see
https://www.librec.net/
Other
3.24k stars 1.03k forks source link

softmax funciton in Maths is not right #194

Closed Trangle closed 6 years ago

Trangle commented 7 years ago

When x[i] is very large, the value after exp would be wrong, you need minus the maximum value of the input vector

SunYatong commented 7 years ago

@Trangle Thanks for your feedback. Your suggestion is more mathematically robust and we will modify our code.