AoBPR Implementation Typo of P(f|c)

guoguibing / librec

LibRec: A Leading Java Library for Recommender Systems, see

https://www.librec.net/

Other

3.23k stars 1.03k forks source link

AoBPR Implementation Typo of P(f|c) #328

Open AaronHeee opened 4 years ago

AaronHeee commented 4 years ago

According to eq (17) in the original WSDM paper, p(f|c) is based on |v_{c,f}| * std(f).

However, in librec AoBPR implementation here, p(f|c) is calculated with variance(f) directly. I'm wondering whether it is a bug in AoBPR implementation. Correct me please if I misunderstand something.