search

guoguo12 / messenger-shortcuts

Keyboard shortcuts for the Facebook Messenger web app (messenger.com).
https://chrome.google.com/webstore/detail/keyboard-shortcuts-for-me/elgfaolomlhhmppjdicpgpmglkllebfb?hl=en-US&gl=US
19 stars 9 forks source link

Added an enter hotkey to select the first search result #2

Closed TerranceN closed 8 years ago

TerranceN commented 8 years ago

Adds the ability to hit enter when searching in order to select the first result.

Also re-focuses the messenger textbox so that if you search for the person you're currently talking to, the flow is the same as if it was someone else (otherwise you have to manually press enter to get back to the message textbox).

I also added a more consistent way to select the message textbox (see focusMessageInput), so that it can be selected even if it has input. If you tried to search for the conversation you're already in and you had entered text, you couldn't get back to it.

guoguo12 commented 8 years ago

This looks awesome! I promise I'll take a look as soon as I get home from my trip!

On Tue, Mar 22, 2016 at 11:10 AM, Terrance Niechciol < notifications@github.com> wrote:

https://camo.githubusercontent.com/1a0a94160c31ac770bcd571429cc4670b4f337dd/687474703a2f2f672e7265636f726469742e636f2f7762315258446d5936652e676966

Adds the ability to hit enter when searching in order to select the first result.

Also re-focuses the messenger textbox so that if you search for the person you're currently talking to, the flow is the same as if it was someone else (otherwise you have to manually press enter to get back to the message textbox).

I also added a more consistent way to select the message textbox (see focusMessageInput), so that it can be selected even if it has input. If you tried to search for the conversation you're already in and you had entered

text, you couldn't get back to it.

You can view, comment on, or merge this pull request online at:

https://github.com/guoguo12/messenger-shortcuts/pull/2 Commit Summary

  • Added an enter hotkey to select the first search result

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/guoguo12/messenger-shortcuts/pull/2

guoguo12 commented 8 years ago

Merged! Will publish ASAP. :) Thanks for contributing! (I've given you push access in case you come across any other changes you want to make.)

guoguo12 commented 8 years ago

Oh BTW, what software did you use to make that nifty GIF demo?

TerranceN commented 8 years ago

Ok, cool. Once I get time to get around to it I plan on making a settings page to customize the shortcuts. Either that or making it so you can change them inline on the help screen. When I do that I'll just work off a branch and make a PR.

And for the gif I used recordit. It became a "thing" at the last company I worked at to include a gif for frontend changes, so when making this PR I figured why not?

sarangjo commented 7 years ago

This might need to be updated, since now the search feature includes a "Search for messages for" bar when searching. I might try to make a PR for this, but just wanted to give a heads-up.

guoguo12 commented 7 years ago

Thanks for the heads-up! Let me know when the PR is ready and I'll merge it ASAP.

sarangjo commented 7 years ago

Just posted the PR (#6)! Sorry about the insane delay, you know how school is. :)