search

guoguo12 / messenger-shortcuts

Keyboard shortcuts for the Facebook Messenger web app (messenger.com).
https://chrome.google.com/webstore/detail/keyboard-shortcuts-for-me/elgfaolomlhhmppjdicpgpmglkllebfb?hl=en-US&gl=US
19 stars 9 forks source link

Insert DOM elements with `textContent` or `createElement` instead of `innerHTML` #9

Open sarangjo opened 7 years ago

sarangjo commented 7 years ago

From a recent Firefox review:

This add-on is creating DOM nodes from HTML strings by assigning to innerHTML. It is recommended to use textContent or createElement then append to Dom. (ref: L183, L186 in messenger-shortcuts.js)

guoguo12 commented 7 years ago

Interesting. I wasn't aware of the drawbacks associated with modifying innerHTML. In this particular case, I don't think it's harmful, but it's worth fixing. Props to the person who made this suggestion!