nus-pe-script
commented
3 months ago Team's Response
We are trying to describe how predicate filters the list. Checking types was done by the parser and this diagram is purely for the execution of the filter.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: From the image below, the activity diagram is shown under "How the feature is implemented" section. This makes me think that the activity diagram was implemented for this section. Moreover, under the section, the team wrote "It first checks, what attribute keywords are provided by the user." so after the user execute the command it should check the attribute keyword first.
To add on
Looking at the activity diagram and the implementation in FindCommandParser.java, I am not sure how can the check be concurrent.
After the user executes the command, it should be a condition to check the TYPE such as name, area or address, before checking the keywords.