search

guokweijie / pe

0 stars 0 forks source link

Add command does not handle multiple semesters input #5

Open guokweijie opened 1 year ago

guokweijie commented 1 year ago

Steps to reproduce:

"add CS2040 s2 s1"

Expected:

Application to detect multiple semesters input and reject command

Actual:

Module is added with only 1 of the semester inputs, the first one.

Before:

image.png

After:

image.png

nus-se-script commented 1 year ago

Team's Response

It was our design choice to have relaxed parsing because it gives more flexibility for fast typists just in case they have any typos, and is more resilient to errors.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The app should have accounted for this edge case, that the user may accidentally enter more than 1 semester inputs at once. However, no warning was given when the command was executed or the app did not stop the command from executing. This may cause problems for the user as the user may add the module to the wrong semester without knowing.

Even if this was your design choice and it was intended, you should have included in your UG that the add command takes the first input for semester and ignores the other inputs following behind. This should be flagged out as a limitation or design choice in UG, as users may key in multiple semesters when they make a mistake with no warning or way to find out. This can potentially cause problems for the user as the module is added under the wrong semester. This can be considered a documentation Bug if you had forgotten to mention it in your UG.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This bug can cause occassional inconvenience to some users if they made a mistake of adding 2 semester inputs and actually want the second input as their semester but did not realise their mistake. As the app does not have an easy way to just change the semester of the module added, the user has to remove the whole module if they have realised the semester entered is wrong, along with the lesson slots added to it, if any. This can cause problems for the user as the user has to re enter all of the information in again, the module and correct semester, and the lesson slots selected. This is why I feel that the bug should be considered medium severity for careless users who do not check regularly and finds out their mistake much later on, as it is causes a lot of inconvenience for users if they have to delete everything for a module and add in everything again one by one.