guokweijie / pe

0 stars 0 forks source link

Application does not check if user has picked the lesson slots that have conflicts in timing #9

Open guokweijie opened 1 year ago

guokweijie commented 1 year ago

Steps to reproduce:

add cs2030 s1

add cs2040 s1

pick cs2030 lab 10d

pick cs2040 lab 2a

Expected: Application to warn user that there is a conflict in timing.

Actual: The app allows the user to pick both timings, even though they clash.

The user guide should warn the user that the onus is on the user to check for clashes in lesson timings.

image.png

soc-se-bot commented 1 year ago

Team's Response

This seems like a suggestion for our feature instead of a bug because our UG only mentioned that you can pick tutorial slots and add modules, but nothing about checking whether the tutorial slots clash with each other.

We reject this suggestion because some people might choose to add in all potential lesson timings they want when planning for modules to take and timetable management. Hence, we decide to put down the feature of allowing users to put classes/tutorials at the same time. Furthermore, we have never mentioned the feature of checking for timetable clashes in our user guide or user story.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: When there is a conflict in timings of slots, this can cause problems for the user as it can confuse the user to think that he/she has successfully managed to fit in all of his/her slots for all modules without any clashes. I am not saying that you cannot allow this operation to go through, but there should be at least a warning to user that there is a conflict in timings for different lesson slots, to warn or remind the user that he should not have such a plan to have conflicts in timingsm in case the user made a mistake or forgot too. Precisely, this is why to mitigate this limitation, you should have indicated in your UG that the app does not check for conflicts in timing. But you failed to do so, hence this is considered a feature flaw which may cause problems for the user when planning a proper timetable for the semester.