search

guoqiangqi / PFLD

Implementation of PFLD A Practical Facial Landmark Detector , reference to https://arxiv.org/pdf/1902.10859.pdf
626 stars 166 forks source link

degrees or radians? #63

Open renderless opened 4 years ago

renderless commented 4 years ago

calculate_pitch_yaw_roll returns head pose in degrees but tf.cos() receive radians. will this be an issue?

ideask commented 4 years ago

calculate_pitch_yaw_roll -> degrees tf.cos(radians ) But I don't think it has any effect.

sljlp commented 4 years ago

I think it is ok to just keep the output of calculate_pitch_yaw_roll and the input of tf.cos in the same unit, in spite of whether the unit is degree or radian.Of course it's better to use radians

wyfdodogod commented 1 year ago

I think it is ok to just keep the output of calculate_pitch_yaw_roll and the input of tf.cos in the same unit, in spite of whether the unit is degree or radian.Of course it's better to use radians

even if use radians, still there might be some problem with the cos function , like cos(abs(0.6-0.5))= cos(abs(0.6-(0.5+2*pi))), the problem would be more serious using degree i guess

sljlp commented 1 year ago

maybe the angle needs to be normalized before computing