search

guoyingtao / Mantis

An iOS Image cropping library, which mimics the Photo App written in Swift.
MIT License
900 stars 180 forks source link

Can't implement custom behavior on the rotationDial #293

Closed Mehrdadmaskull closed 1 year ago

Mehrdadmaskull commented 1 year ago

RotationDial, var CropView and RotationDialProtocol are all inaccessible and need to be open so there is access to the protocol's functions to implement custom behavior (like when the user stops the rotation, or get the angle of the rotation etc)

I can work on the changes and create a pull request

guoyingtao commented 1 year ago

@Mehrdadmaskull Thanks for the suggestion. Making those classes open does provide more information like the angle of the rotation, but I am not sure if users really need them. You are welcome to raise a PR then it is easier for us to discuss from there. Also it would be great if you can add an example to show actual scenarios of how to use those new information.

bobby-kim-km commented 1 year ago

🙄

guoyingtao commented 1 year ago

Since it issue has not got any response for more than two months, I close it for now. @Mehrdadmaskull You can reopen it anytime when you want to discuss your pull request.