guoyingtao / Mantis

An iOS Image cropping library, which mimics the Photo App written in Swift.
MIT License
926 stars 183 forks source link

About the color of the cropping border line #401

Closed ByLiangCheng closed 4 months ago

ByLiangCheng commented 4 months ago

I configured the color in config.cropViewConfig.cropBorderColor, but it seems to have no effect after setting it. I wonder if it is supported?

Because my config.cropViewConfig.backgroundColor is set to white, in this case, the crop line and the background color will be the same, making it impossible to see whether it exists, but in fact I need it to be displayed prominently.

I would appreciate any help in resolving this issue.

ByLiangCheng commented 4 months ago

Sample video :

https://github.com/user-attachments/assets/833097e3-7794-453f-9fd4-633a3f08b70f

guoyingtao commented 4 months ago

@ByLiangCheng config.cropViewConfig.cropBorderColor is for the border of the cropped image like below, it is not for the cropping box whose border is always white currently.

image
ByLiangCheng commented 4 months ago

Will you consider supporting the configuration of a cropping frame that is always white in the future? Because when my background is white, the cropping frame is always white, which makes it invisible.

guoyingtao commented 4 months ago

@ByLiangCheng Yes, I will consider supporting this configuration in the next release.

ByLiangCheng commented 4 months ago

Thanks, looking forward to the update

mihapp commented 4 months ago

I'm also looking forward for this update, I have similar issue with white background...

guoyingtao commented 4 months ago

@ByLiangCheng @mihapp Can you try PR #403 to see if it meets your requirement?

You may need to modify color properties of CropViewConfig.cropAuxiliaryIndicatorConfig

ByLiangCheng commented 4 months ago

@ByLiangCheng @mihapp Can you try PR #403 to see if it meets your requirement?

You may need to modify color properties of CropViewConfig.cropAuxiliaryIndicatorConfig

Thank you for your support, I successfully solved it with this configuration

guoyingtao commented 4 months ago

@ByLiangCheng I released Mantis 2.22.0 which includes PR #403