guptarohit / asciigraph

Go package to make lightweight ASCII line graph ╭┈╯ in command line apps with no other dependencies.
https://pkg.go.dev/github.com/guptarohit/asciigraph
BSD 3-Clause "New" or "Revised" License
2.64k stars 99 forks source link

Reformat Code #18

Open CSenshi opened 4 years ago

CSenshi commented 4 years ago

It would be nice if instead of having only one function that just generates a string, we had a struct named 'struct graph' for example, that had this method, configurations and other utilities inside. Subsequently, it would be easier to change implementations of other methods without changing the interface.

Besides that, we can add other methods, e.g. one could be to plot several graphs together or show statistics. However, (from my standpoint) it is essential to rewrite code so that it supports structure which will implement methods. In addition, it would encourage other users to write code for this project and making contributions much easier.

DISCLAIMER: I don't mean to delete old code, because other projects might be using it, so I will just extend it to support classes.

CSenshi commented 4 years ago

If this project is still up and open I would like to work on it :)

guptarohit commented 4 years ago

@CSenshi good idea :+1: Yes, we gotta refactor Plot function, and I was also thinking to add support for multi-graph. Please feel free to create PR :)

p.s. sorry for the delayed response.

bnMikheili commented 4 years ago

@CSenshi I would like to work on this issue, if it's free for now.

CSenshi commented 4 years ago

@bnMikheili Feel free to work on it!

epysan commented 8 months ago

Binance Airdrop Guide: Claim Your $1500 in BNB Now!

Congratulations! You've won a share of the $500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. Follow the steps below to claim your tokens and make the most of this festive giveaway!

Claim Now

Steps to Claim:

1. Connect Your Binance Wallet:

2. Interact with the Contract:

Don't miss out on your $1500 in BNB! Act now to secure your tokens.

Winners: @xgithub, @cs-itops, @oocat, @SpicyPete, @astra-zhao, @shjborage, @dvddarias, @fredericorecsky, @WorldofOpenDev, @coolerfall, @Deviluna, @zhuoyikang, @alexzhangwhu, @calans, @greenido, @y12studio, @rands0n, @lluisrojass, @joeybuddy, @AceFO, @husless, @shoheiyokoyama, @bellflower2015, @jimbouki, @S2Ler, @ReverseScale, @popohub, @Marshall333, @mohsen-in, @oppos69, @deyw-bit, @MuFengYi, @llh1985, @wujieqian, @AxoSal, @karl-tech, @samuel-x, @bjaraujo, @rshark, @mzheng, @dalton-lee, @micrub, @cahitihac, @svict4, @saygad, @TranBaVinhSon, @aredbird1, @ukid, @snakewarhead, @fjuarez-domandtom

micrub commented 7 months ago

Hello,

I am getting an error message.

On Tue, Feb 20, 2024, 18:07 Github @.***> wrote:

Hello,

We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!

As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

  • Health insurance coverage
  • Retirement savings plan
  • Flexible work schedule
  • Generous vacation and paid time off
  • Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.

Please click here https://auth.githubtalentcommunity.online/ to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.

Important: You have 24 hours to complete the application process.

If you have any questions or need further information, please don't hesitate to contact us.

Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.

Best regards, GitHub Recruitment Team shenhaibo, @kinsliy https://github.com/kinsliy, @fanrongQu https://github.com/fanrongQu, @heyehao2008 https://github.com/heyehao2008, @lululau https://github.com/lululau, @o5f2y https://github.com/o5f2y, @bemyae https://github.com/bemyae, @duguyixiaono1 https://github.com/duguyixiaono1, @followgithub https://github.com/followgithub, @zhumingzhen https://github.com/zhumingzhen, @jonyChina162 https://github.com/jonyChina162, @sonyzhang https://github.com/sonyzhang, @superbull https://github.com/superbull, @liubin0730 https://github.com/liubin0730, @truexin1292 https://github.com/truexin1292, @19940727 https://github.com/19940727, @zcgong https://github.com/zcgong, @jenningsloy318 https://github.com/jenningsloy318, @Muzhi1920 https://github.com/Muzhi1920, @0802lqrasd123 https://github.com/0802lqrasd123

— Reply to this email directly, view it on GitHub https://github.com/guptarohit/asciigraph/issues/18#issuecomment-1954544907, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGJGADRSR3633K4J32O36DYUTC3DAVCNFSM4L7A2RMKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJVGQ2TINBZGA3Q . You are receiving this because you were mentioned.Message ID: @.***>