Added Equal method to nulltypes.

guregu / null

reasonable handling of nullable values

BSD 2-Clause "Simplified" License

1.84k stars 238 forks source link

Closed MarkKremer closed 4 years ago

MarkKremer commented 6 years ago

I added the methods as discussed in #35 . The methods are called Equal instead of Equals (with -s) to be more consistent with the go library.

Interesting bits:

Time can be compared using Equal (uses time.Time.Equals) and ExactEqual (uses the ==-operator)
Equal is implemented for Float. The doc above the method mentions that comparing floats is not always recommended.

guregu commented 6 years ago

Thanks for the PR! LGTM. I’ll add the equivalent methods to the zero package and merge this soon (ETA: this weekend)

abramche commented 4 years ago

Any news @guregu?