search

gurghet / vue-smart-table

A simple table component for interactive tables built with Vue.js
http://www.gurghet.com/vue-smart-table
MIT License
143 stars 20 forks source link

Doesn't work in Safari and FF #4

Closed lavezzi1 closed 8 years ago

lavezzi1 commented 8 years ago

I test my pages which contain smart-table component and I found that they doesn't display in Safari (last version) and Firefox. One error display in console of the browsers

TypeError: CSS.escape is not a function. (In 'CSS.escape(col)', 'CSS.escape' is undefined)

gurghet commented 8 years ago

Thanks! That is a biggie. Should be fixed in 2.4.1

lavezzi1 commented 8 years ago

@gurghet Firefox is fixed, thanks! But Safari still has a bug. It highlights this line of code if (father.addRow === true && (father.addRowCompiled[col] === false || father.addRowCompiled[col] === undefined)) {

gurghet commented 8 years ago

I wasn't able to reproduce the problem on Safari 9.1.1, anyways I suspect that the CSS polyfill wasn't picked up for some reason. I forced smart table to use the polyfill even in normal browsers, so it should work in 2.4.2. Let me know.

lavezzi1 commented 8 years ago

Yes, works like a charm. Thank you.