search

gurisko / cordova-plugin-accountkit

AccountKit Plugin for Apache Cordova which allows you to add passwordless email and SMS authentication to your app
MIT License
34 stars 42 forks source link

Added browser platform; Use the latest AccountKit SDK for both iOS and Android platform #43

Closed eddy-lau closed 6 years ago

gurisko commented 6 years ago

Hey @eddy-lau ! Thank you very much for the pull request. Please give me a day to do a quick review.

The-Don-Himself commented 6 years ago

ping @gurisko in case you had some time over the weekend.

gurisko commented 6 years ago

Thank you @eddy-lau very much for the PR and @The-Don-Himself for the ping. I didn't have much time testing it on both platforms but the code seemed to be good. Let's see what is the community feedback with the version 1.4.0.

The-Don-Himself commented 6 years ago

Thanks too @eddy-lau and @gurisko for merging. I'll try test it soon and report back any issues/features. Will you be tagging a new release?

gurisko commented 6 years ago

The release is out. Feel free to test it out directly - 1.4.0

eddy-lau commented 6 years ago

Thanks for merging my pull request. (@mfkenson).