gurisko / cordova-plugin-accountkit

AccountKit Plugin for Apache Cordova which allows you to add passwordless email and SMS authentication to your app
MIT License
34 stars 42 forks source link

Android build error in ionic capacitor #59

Open Kaoschuks opened 5 years ago

Kaoschuks commented 5 years ago

Whenever i build my ionic capacitor app for android i get

E/AccountKitPlugin: java.lang.IllegalArgumentException: Can only use lower 16 bits for requestCode at android.support.v4.app.BaseFragmentActivityApi14.checkForValidRequestCode(BaseFragmentActivityApi14.java:79) at android.support.v4.app.FragmentActivity.startActivityForResult(FragmentActivity.java:748) at org.apache.cordova.CordovaInterfaceImpl.startActivityForResult(CordovaInterfaceImpl.java:68) at org.apache.cordova.facebook.AccountKitPlugin.executeLogin(AccountKitPlugin.java:136) at org.apache.cordova.facebook.AccountKitPlugin$1.run(AccountKitPlugin.java:56)

Kaoschuks commented 5 years ago

I need an answer on this please can anybody from the accountkit team help

jcesarmobile commented 5 years ago

You have to change this number to be a bit smaller https://github.com/gurisko/cordova-plugin-accountkit/blob/master/src/android/AccountKitPlugin.java#L31

Kaoschuks commented 5 years ago

I have reduced it to 65530 but it didn't work.

Please try and fix it please if possible please

Kaoschuks commented 5 years ago

I fixed it for android works wonderfully

jcesarmobile commented 5 years ago

Linking PR https://github.com/gurisko/cordova-plugin-accountkit/pull/64

Kaoschuks commented 5 years ago

Thanks On Wednesday, June 26, 2019, 02:09:23 PM GMT+1, jcesarmobile notifications@github.com wrote:

Linking PR #64

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.