gurkankaymak / hocon

go implementation of lightbend's HOCON configuration library https://github.com/lightbend/config
MIT License
79 stars 17 forks source link

fix: fix the object String() function error when the element have ":" #19

Closed Rory-Z closed 2 years ago

Rory-Z commented 2 years ago

Fix https://github.com/gurkankaymak/hocon/issues/16

codecov[bot] commented 2 years ago

Codecov Report

Merging #19 (5ed08ff) into master (8573646) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   96.67%   96.69%   +0.01%     
==========================================
  Files           3        3              
  Lines         722      726       +4     
==========================================
+ Hits          698      702       +4     
  Misses         17       17              
  Partials        7        7              
Impacted Files Coverage Δ
config.go 93.80% <100.00%> (+0.10%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gurkankaymak commented 2 years ago

thanks for the contribution, requested minor test changes otherwise looks good to me

Rory-Z commented 2 years ago

thanks for the contribution, requested minor test changes otherwise looks good to me

What do I need to do ?

gurkankaymak commented 2 years ago

you can see line comments above, I think tests should be added as a separate case, in example

t.Run("return the string of an object that contains a string element with the ':' character", func(t *testing.T) { got := Object{"a": String("0.0.0.0:80")}.String() assertEquals(t, got, {a:"0.0.0.0:80"}) })

Rory-Z commented 2 years ago

you can see line comments above, I think tests should be added as a separate case, in example

t.Run("return the string of an object that contains a string element with the ':' character", func(t *testing.T) { got := Object{"a": String("0.0.0.0:80")}.String() assertEquals(t, got, {a:"0.0.0.0:80"}) })

Cool, I will change code

Rory-Z commented 2 years ago

When do we plan to release the next version? I'm looking forward to it.

gurkankaymak commented 2 years ago

just published a new release https://github.com/gurkankaymak/hocon/releases/tag/v1.2.7

Rory-Z commented 2 years ago

just published a new release https://github.com/gurkankaymak/hocon/releases/tag/v1.2.7

So cooooooool